Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix debian package generation process and add to CI #593

Merged
merged 3 commits into from
Apr 7, 2024
Merged

fix debian package generation process and add to CI #593

merged 3 commits into from
Apr 7, 2024

Conversation

bennibbelink
Copy link
Contributor

Closes #592. Adds steps to publish_release.yml to build a Debian package and upload it to the release.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 4, 2024 •
edited
Loading

Build Status Report - 73c2dc8 - 2024-04-05 01:40:29 +0000

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️

@bennibbelink
Copy link
Contributor Author

Tested on my fork - https://github.com/bennibbelink/cycamore/releases/tag/1.6.4

I'm able to install cycamore on a fresh ubuntu:22.04 image using the cyclus .deb and cycamore .deb, all cycamore_unit_tests pass.

@bennibbelink
Copy link
Contributor Author

Unfortunately CI won't pass on this PR until a cyclus:stable image exists.

@bennibbelink bennibbelink requested a review from gonuke April 5, 2024 02:04
@gonuke
Copy link
Member

gonuke commented Apr 5, 2024 •
edited
Loading

Do you think we should wait to merge, or go ahead now, and repair if there are issues later

@bennibbelink
Copy link
Contributor Author

Best practice would probably suggest we wait. However, potential issues would likely be noticed in the Cyclus release first since they follow the same general procedure - so we would have the opportunity to apply fixes before we issue a cycamore release. I think I lean towards merging and getting the two repos in the same state now (in terms of Deb generation) instead of having them out of sync and trying to catch up cycamore and patch issues all in one go.

gonuke
gonuke approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bennibbelink - let's see how this works on our release.

@gonuke gonuke merged commit d51aa95 into main Apr 7, 2024
19 of 23 checks passed
@bennibbelink bennibbelink deleted the deb-generation branch April 8, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debian Packages are not uploaded to release
2 participants
@bennibbelink @gonuke